Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added run das queries test for PRs; reset statues on rerun #1412

Merged
merged 4 commits into from
Nov 11, 2020
Merged

added run das queries test for PRs; reset statues on rerun #1412

merged 4 commits into from
Nov 11, 2020

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Nov 11, 2020 •
edited
Loading

This adds a new tests for Pull requests testing. Tests make use of runTheMatrix.py --maxStep=0 option to run all das query steps. This should catch if there is any new data being access which is not yet known to DAS.

The extra test should not take more than 8-10 mins to run.

Also reset PR statuses to pending it rests are rerun.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #1412 was updated.

@cmsbuild
Copy link
Contributor

Pull request #1412 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #1412 was updated.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 11, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@smuzaffar smuzaffar changed the title added run das queries test for PRs added run das queries test for PRs; reset statues on rerun Nov 11, 2020
@cmsbuild
Copy link
Contributor

+1
Tested at: 4817811
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-118832/10645/summary.html
CMSSW: CMSSW_11_2_X_2020-11-10-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@smuzaffar smuzaffar mentioned this pull request Nov 11, 2020
Closed
@smuzaffar smuzaffar merged commit 60849d5 into master Nov 11, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-118832/10645/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2529296
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2529267
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 148 log files, 22 edm output root files, 35 DQM output files

@silviodonato silviodonato mentioned this pull request Nov 14, 2020
Merged
@smuzaffar smuzaffar deleted the run-das-query-test branch November 27, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild